redesign: Academic Path - Schedule #1445
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (11%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## ui/redesign #1445 +/- ##
============================================
- Coverage 11% 11% -0%
============================================
Files 270 274 +4
Lines 7358 7492 +134
============================================
+ Hits 807 808 +1
- Misses 6551 6684 +133 |
…tent and to color when selected)
…ne for the Schedule Page to allow for the needed requirements.
|
Care for the use of |
…onalities to the general timeline. Slight visual improvements.
Now using CardTimeline and the Generic Timeline. Please verify if the changes made to the generic timeline in order to support the same functionalities as the schedule_timeline are correct and can be done without compromising its use for other pages. |
…o different files.
| SchedulePageState createState() => SchedulePageState(); | ||
| } | ||
|
|
||
| class SchedulePageState extends State<SchedulePage> { |
There was a problem hiding this comment.
I don't think this needs to be stateful. You can just create it as StatelessWidget and pass DateTime now as parameter
There was a problem hiding this comment.
I've changed it to a StatelessWidget and rebased the branch with the latest ui/redesign updates, but encountered a new issue. The update to the general page layout uses extendBody: true to allow the body to appear behind the bottom navbar, but that is making the padding between each day's content to extend unexpectedly. I am not sure why that is happening or how to fix it.
… in sync; changed SchedulePage from StatefulWidget to Stateless.
…ectures in the week; refactor: renamed academic_schedule_card.dart to schedule_day_timeline.dart for consistency.
Closes #1424
Since there are no classes this week, to completely test the schedule page we need to add mock lectures. So, when the page becomes ready to merge we need to delete them first.
Review checklist
whatsnew/whatsnew-pt-PTchangelog.mdwith the change